Async callback functions, partnership function, rsaes_oaep for KeyEncryptionAlgorithm #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix github action build fail due to:
Feature/force binary
# Conflicts: # setup.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 96.45% 96.78% +0.32%
==========================================
Files 6 6
Lines 734 778 +44
Branches 131 147 +16
==========================================
+ Hits 708 753 +45
+ Misses 14 13 -1
Partials 12 12 ☔ View full report in Codecov by Sentry. |
|
can we split the changes into 3 PRs? |
|
Would be earliest in May. And was trying to avoid merge conflicts. Which order/separation would you like to get them? |
|
Closed to split into separate PR's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding following features:
I am wondering if this should be last version to support python 3.7 and with next version we should upgrade python 3.8 - python 3.12? This also means, we have to upgrade some packages as well. Had to upgrade pytest for better async testing support.